refactor: remove unused public API

[nicolasnoble]

Nine public items across the three crates have no consumer in this repository and none in dynamo, checked against its origin/main because the local checkout is far behind. The crates carry two, three and zero reverse dependencies on crates.io.

In modelexpress_common: the ConfigLoader trait and its load_layered method, which had no impl and no caller, the real path being the free function load_layered_config which stays; CacheConfig::from_server, a permanent Err stub; the POD_NAME and POD_UID name constants, with POD_NAMESPACE staying because backend_config.rs reads it; SealedArtifactManifest::to_header_response and to_chunks_response, which build WorkerService responses for a service with no Rust implementation; the Network variant of the shared Error enum, whose other seven variants stay; and ClientConfig::with_cache_path, whose with_endpoint, with_timeout and for_testing counterparts are live and stay.

In modelexpress_client: five Client cache-management methods, get_cache_config, set_cache_config, list_cached_models, clear_cached_model and clear_all_cached_models. The CLI reaches CacheConfig directly and never calls any of them.

In modelexpress_server: CacheEvictionService::manual_evict, and the three-argument set_status wrapper that only delegated to set_status_and_notify with no message. The RegistryBackend trait method of the same name takes four arguments and is untouched.

POD_NAME and POD_UID remain live in the Python client, which defines and consumes them, so the Downward API documentation is still accurate and unchanged. EvictionReason::Manual is left in place: it becomes unconstructable here, but CountLimit and DiskSpace already were, so removing only Manual would be arbitrary and removing all three is a question about whether those eviction policies are still planned.

Three unit tests go with the items they covered, along with a test helper and a page-size constant used only by to_chunks_response. Verified with cargo clippy --workspace --all-targets --all-features -D warnings, which is the load-bearing check because it compiles every target, and with the lib suites at 35, 176 and 248 passing.

Summary by CodeRabbit

• Refactor

  • Streamlined model cache management by removing client-side cache inspection, configuration overrides, and manual eviction controls.
  • Simplified artifact manifest handling by removing paginated chunk metadata support.
  • Consolidated configuration loading and download-status handling by removing legacy convenience interfaces.

• Breaking Changes

  • Applications using the removed cache, configuration, manifest pagination, environment constant, or error interfaces must update their integrations.
  • Model deletion continues to remove stale server-side registry records after local files are cleared.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c6e6714b-21c2-4762-9c62-52a6f77ccff3

📥 Commits

Reviewing files that changed from the base of the PR and between 9abaf2d and b682a2b.

📒 Files selected for processing (9)

• modelexpress_client/src/lib.rs
• modelexpress_common/src/artifact_manifest.rs
• modelexpress_common/src/cache.rs
• modelexpress_common/src/client_config.rs
• modelexpress_common/src/config.rs
• modelexpress_common/src/envs.rs
• modelexpress_common/src/lib.rs
• modelexpress_server/src/cache.rs
• modelexpress_server/src/services.rs

💤 Files with no reviewable changes (8)

• modelexpress_server/src/cache.rs
• modelexpress_common/src/config.rs
• modelexpress_server/src/services.rs
• modelexpress_common/src/client_config.rs
• modelexpress_common/src/lib.rs
• modelexpress_common/src/envs.rs
• modelexpress_common/src/cache.rs
• modelexpress_common/src/artifact_manifest.rs

---

Walkthrough

The change removes unused public APIs for cache management, artifact-manifest pagination, layered configuration, pod environment variables, and network errors. Related imports, tests, fixtures, and implementation paths are also removed.

Changes

Public API cleanup

Layer / File(s)	Summary
Cache control API removal modelexpress_client/src/lib.rs, modelexpress_common/src/cache.rs, modelexpress_common/src/client_config.rs, modelexpress_server/src/cache.rs	The client cache methods, cache configuration helpers, and server manual eviction method are removed.
Manifest pagination removal modelexpress_common/src/artifact_manifest.rs	Chunk response pagination support, related imports, tests, and the large-manifest fixture are removed.
Common contract cleanup modelexpress_common/src/config.rs, modelexpress_common/src/envs.rs, modelexpress_common/src/lib.rs	ConfigLoader, POD_NAME, POD_UID, and Error::Network are removed with their direct tests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to b682a

This PR removes unused public API while preserving the documented live usages, and the reported checks pass; no actionable merge-blocking risk remains beyond normal review.

Poem

I’m a rabbit with a tidy code tree,
Old cache paths vanish quietly.
Chunk pages hop away,
Stale APIs end their day,
Clean contracts now run free.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the removal of unused public APIs across the affected crates.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[zhengluo-nv]

These are in use by ownerReference

[nicolasnoble]

fair, and the doc comment i deleted said "used by clients" which should have stopped me.

but as far as i can tell the ownerReference path runs entirely through python: the downward api sets these on the worker, envs.py declares them, client.py sends pod_name and pod_uid on the request, and pod_owner_references takes them off the request rather than off the server's own environment. i can't find a rust reader for either constant, so the removal should be behaviourally inert.

which leaves the question of what envs.rs is for. POD_NAMESPACE is read in rust at backend_config.rs, so those three sit together today with two of them declaration-only. is envs.rs meant to be the canonical registry for python-only var names as well, or should those live only in envs.py? if it's the registry, i'll put both back and leave the trio alone. if it's rust readers only, POD_NAMESPACE is the one that's correctly there and the other two were always redundant with envs.py.

holding the removal as-is until you say which.