build: drop dependency declarations no crate uses - #632
Conversation
Eleven declarations across four manifests were never referenced by the crate declaring them. Verified by removing them and building: cargo clippy --workspace --all-targets --all-features -D warnings is clean and the lib suites are unchanged at 35, 177 and 249 passing, and --all-targets compiles the test and bench targets, so anything genuinely referenced would have failed to resolve. - modelexpress_server dependencies: hf-hub, jiff, once_cell, toml - modelexpress_client dependencies: prost - dev-dependencies: tokio-test in all four crates, tonic-build in the server and client, mockall in common tonic-build is removed only from the server and client, where it sits in dev-dependencies and neither crate has a build.rs. The copy in common is a build-dependency that compiles the protos and is untouched. mockall is removed only from common, which pinned it directly at 0.13 while the workspace declares 0.14.0, so that crate was building a second major version of it. The server uses the workspace version and still needs it. The lockfile sheds only mockall, mockall_derive, tokio-test and toml_writer, because most of the removed declarations named crates that other members genuinely depend on. This changes what each manifest claims to use, not what the workspace pulls in. Signed-off-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
WalkthroughThe pull request removes unused runtime and development dependencies from four Cargo manifests. ChangesWorkspace dependency cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This PR removes unused dependency declarations and corresponding lockfile entries without changing crate behavior; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Eleven dependency declarations across four manifests were never referenced by the crate declaring them. Verified by removing them and building rather than by grep: cargo clippy --workspace --all-targets --all-features -D warnings is clean and the lib suites are unchanged at 35, 178 and 249 passing. --all-targets compiles the test and bench targets, so anything genuinely referenced would have failed to resolve.
Removed from dependencies: hf-hub, jiff, once_cell and toml in modelexpress_server, and prost in modelexpress_client. Removed from dev-dependencies: tokio-test in all four crates, tonic-build in the server and client, and mockall in common.
tonic-build is removed only from the server and client, where it sits in dev-dependencies and neither crate has a build.rs. The copy in common is a build-dependency that compiles the protos and is untouched. mockall is removed only from common, which pinned it directly at 0.13 while the workspace declares 0.14.0, so that crate was building a second major version of it; the server uses the workspace version and still needs it.
The lockfile sheds only mockall, mockall_derive, tokio-test and toml_writer, because most of the removed declarations named crates that other workspace members genuinely depend on. This changes what each manifest claims to use, not what the workspace pulls in.
Summary by CodeRabbit