Skip to content

build: pin codelytv/pr-size-labeler to commit SHA in pull_request_target workflow#4570

Closed
XananasX7 wants to merge 2 commits into
agones-dev:mainfrom
XananasX7:XananasX7-patch-1
Closed

build: pin codelytv/pr-size-labeler to commit SHA in pull_request_target workflow#4570
XananasX7 wants to merge 2 commits into
agones-dev:mainfrom
XananasX7:XananasX7-patch-1

Conversation

@XananasX7
Copy link
Copy Markdown

/kind cleanup

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Pins codelytv/pr-size-labeler to full commit SHA instead of mutable v1 tag in the labeler.yml workflow.

This workflow uses pull_request_target trigger which runs with write permissions on every PR from forks. Using a mutable tag reference means any compromise of the upstream action repository (tag move,
account takeover) would execute arbitrary code with write access to this repository.

Pinning to SHA ensures the action content is immutable and prevents supply chain attacks via tag manipulation.

Which issue(s) this PR fixes:

N/A — proactive security hardening

Special notes for your reviewer:

This follows GitHub's security best practice of pinning actions to full SHA in privileged workflows. See:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

XananasX added 2 commits May 16, 2026 01:27
…rget workflow

 build: pin codelytv/pr-size-labeler to commit SHA in pull_request_target workflow
@github-actions github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels May 16, 2026
@XananasX7
Copy link
Copy Markdown
Author

I agree to the DCO (Developer Certificate of Origin) for this contribution.

@XananasX7
Copy link
Copy Markdown
Author

Summary

This PR pins codelytv/pr-size-labeler to a full commit SHA in the pull_request_target workflow.

Why this matters

The pull_request_target trigger gives this workflow base-repository context. The codelytv/pr-size-labeler action uses a mutable version tag, making it a viable supply chain attack vector — a compromised tag could run arbitrary code with repository write access on every PR.

Fix

Pinned to the exact commit SHA with a version comment. Minimal change, no logic impact. DCO signed. Ready for review.

@markmandel
Copy link
Copy Markdown
Member

CodelyTV/pr-size-labeler@56070d7 also not a commit. Closing and banning account due to security concerns.

@markmandel markmandel closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants