Repository navigation
Run helm_deployment post_renderers on deploy (2.33.0+cipherowl.8) - #5
Merged
aegis-cipherowl merged 1 commit intoNov 13, 2026
Merged
Conversation
prepare_post_renderer_for_helm_deployment never passed the deployment's post_renderers to SetupHelmPostRenderer, so only the built-in image-ref post-renderer ran and the field was silently ignored. Pass the field through as extra_post_renderers when it is set, and add a rule test whose chained renderer rewrites the ref the built-in renderer produced, so it only passes when both run, in order. The existing test_use_simple_extra_post_renderer only passed because its renderer never ran: its run_shell_command used a build-root-relative command with the default workdir (the BUILD dir). Set workdir="/" there. Stamp the version as 2.33.0+cipherowl.8. INF-2315 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INF-2315
Problem
helm_deployment(post_renderers=[...])never runs on deploy.prepare_post_renderer_for_helm_deploymentbuiltSetupHelmPostRendererwithoutextra_post_renderers, so only the built-in image-ref post-renderer ran, and the chaining code insubsystems/post_renderer.pywas never reached.Change
field_set.post_renderers.to_unparsed_address_inputs()asextra_post_rendererswhen the field is set.test_deployment_post_renderers_are_chained_after_builtin. Its chained script rewritesapp:latest, which is the ref the built-in renderer writes, toapp:chained. So the test passes only if both renderers run, in that order. Without the fix it fails, and the output still showsapp:latest.test_use_simple_extra_post_renderer. That test only passed because its renderer never ran. Itsrun_shell_commandused a build-root-relativecommandwith the defaultworkdir(the BUILD dir). Once wired up, it failed withNo such file or directory. It now setsworkdir="/".VERSION→2.33.0+cipherowl.8.Testing
pants test src/python/pants/backend/helm::: all 26 targets pass. Five targets hit the 60s default timeout under local parallel load and pass when rerun alone with a longer timeout.pants fmt lint checkon the touched files: clean.Note for consumers
run_shell_commandpost-renderers run withworkdirdefaulting to the BUILD file's directory. So a renderer whosecommandis a build-root-relative path needsworkdir="/".🤖 Generated with Claude Code