Skip to content

feat(button): 2nd-gen migration plan#6176

Merged
5t3ph merged 11 commits intomainfrom
swc-1873/button-migration-plan
Apr 24, 2026
Merged

feat(button): 2nd-gen migration plan#6176
5t3ph merged 11 commits intomainfrom
swc-1873/button-migration-plan

Conversation

@5t3ph
Copy link
Copy Markdown
Contributor

@5t3ph 5t3ph commented Apr 14, 2026

Description

Provides the migration plan for Button, per washing machine guidelines.

Related issue(s)

  • SWC-1875

Reviewer's checklist

  1. Ensure all expected content is included in the migration plan
  2. Help answer any outstanding questions, especially blockers
  3. Help validate/provide feedback for scope, API, and changes/additions

@5t3ph 5t3ph requested a review from a team as a code owner April 14, 2026 19:59
@5t3ph 5t3ph added Status:WIP PR is a work in progress or draft Component:Button Includes ButtonBase, Clear Button, and Close Button 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. labels Apr 14, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: 3c010a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6176

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Copy link
Copy Markdown
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions posed here. See my comments for my thoughts.

Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Comment thread CONTRIBUTOR-DOCS/03_project-planning/03_components/button/migration-plan.md Outdated
Copy link
Copy Markdown
Contributor

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments but I don't see anything inherently blocking that can't be addressed during the migration itself 😄
Also, this reads great, awesome work.

@5t3ph 5t3ph added Status:Ready for re-review PR has had its feedback addressed and is once again ready for review. and removed Status:WIP PR is a work in progress or draft labels Apr 23, 2026
@5t3ph 5t3ph enabled auto-merge (squash) April 24, 2026 15:08
@5t3ph 5t3ph merged commit 0c60a8a into main Apr 24, 2026
27 of 30 checks passed
@5t3ph 5t3ph deleted the swc-1873/button-migration-plan branch April 24, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Component:Button Includes ButtonBase, Clear Button, and Close Button Status:Ready for re-review PR has had its feedback addressed and is once again ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants