Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
|
|
||
| | Jira | Type | Status (snapshot) | Resolution (snapshot) | Summary | | ||
| |------|------|-------------------|-------------------------|---------| | ||
| | [SWC-1044](https://jira.corp.adobe.com/browse/SWC-1044) | Story | Blocked | Unresolved | [Refactor] Migrate Picker to use FormFieldMixin, adding placeholder property to Picker | |
There was a problem hiding this comment.
Comment: Wow! It will be awesome to be able to resolve these tickets once this component can be migrated. Will the recommendation be to use s2, and therefor be able to close these tickets? Just curious. Great work!
|
|
||
| ## Overview | ||
|
|
||
| This file is a **placeholder** for **`swc-picker`** rendering, CSS, and DOM migration planning. Until it is expanded, treat **`1st-gen/packages/picker/src/Picker.ts`** (`<sp-picker>`) as the primary reference for structure and behavior. |
There was a problem hiding this comment.
Question: Is there a ticket for this migration planning doc update?
There was a problem hiding this comment.
Seems like an opportunity for a @todo with a ticket #.
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.