feat(schema): add DOOH structured selling-unit fields to placements#5623
Open
garvitkaushik-123 wants to merge 1 commit into
Open
feat(schema): add DOOH structured selling-unit fields to placements#5623garvitkaushik-123 wants to merge 1 commit into
garvitkaushik-123 wants to merge 1 commit into
Conversation
Add dooh_placement_attributes (slot_duration_seconds, loop_duration_seconds, screen_resolution, motion) and identifiers[] to both placement.json and placement-definition.json. Create dooh-motion-type enum. Update identifier-types title to channel-neutral language. Add superseded note to flat-rate-option loop_duration_seconds. Document DOOH placement attributes in media-products docs. Closes adcontextprotocol#5537 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.
This is an automated message from the Argus AI review workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #5537 — adds structured DOOH selling-unit metadata to placements so buyers can evaluate screen characteristics during product discovery.
dooh_placement_attributesobject on bothplacement.jsonandplacement-definition.jsonwith four optional fields:slot_duration_seconds— duration of one ad slotloop_duration_seconds— full loop rotation (canonical source, supersedes pricing-layer field)screen_resolution— physical{ width, height }in pixelsmotion—full_motion,partial_motion, orstatic(newdooh-motion-typeenum)identifiers[]array on both placement schemas — reuses the{ type, value }pattern from property identifiers for DOOHvenue_id,screen_id,openooh_venue_type, etc.dooh-motion-type.jsonenum —full_motion,partial_motion,staticidentifier-types.jsontitle updated from "Property Identifier Types" to channel-neutral "Identifier Types"flat-rate-option.jsonloop_duration_secondsdescription updated with superseded noteDesign decisions
video_placement_types,audio_distribution_types, etc.) — new fields sit alongside those in the same positionadditionalProperties: trueondooh_placement_attributesto allow future field additions without breaking changesidentifiers[]is channel-neutral by design — reuses the same enum already used for property identifiersmotionenum values align with industry conventions (OpenOOH/OAAA terminology)Test plan
build:schemas) succeedsCloses #5537
🤖 Generated with Claude Code