fix(verify/worldid): require a resolvable adcp-go version for external import#375
Open
bokelley wants to merge 1 commit into
Open
fix(verify/worldid): require a resolvable adcp-go version for external import#375bokelley wants to merge 1 commit into
bokelley wants to merge 1 commit into
Conversation
…l import verify/worldid is a separate module meant to be imported (e.g. by scope3data/rtdp), but its go.mod required `adcp-go v0.0.0` — a placeholder that only resolves in-repo via `replace => ../..`. External consumers ignore the replace, so the require failed to resolve and the module couldn't be imported. Pin the require to the real pseudo-version of the module's commit; keep the replace for in-repo local dev. Validated with an external module that replaces only verify/worldid to local: it now resolves adcp-go root from the proxy and builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Correct fix for a real external-import break. The placeholder v0.0.0 only ever resolved through the in-repo replace, so any external consumer (scope3data/rtdp on the World Ads operator path) hit an unresolvable require — pinning to a proxy-resolvable pseudo-version is the right shape.
Things I checked
- Pseudo-version is real, not invented.
v0.0.0-20260610020654-c0720af293c1decodes exactly: commitc0720af293c1committed2026-06-09T22:06:54-04:00→20260610020654ZUTC, hash prefix matchesc0720af293c19930135a8cce44c5035bf38ab4ad. The format is valid and the commit is onmain, so external proxies can resolve it. replace github.com/adcontextprotocol/adcp-go => ../..is preserved (verify/worldid/go.mod:14). In-repo CI still builds against local root; the require pin only matters when the replace is dropped — i.e. exactly the external-import case.- Conventional-commit type is correct:
fix(verify/worldid):. No exported symbol removed/renamed, no wire change, no breaking marker needed. - No source diff, no schema/types touch, no tmproto/signing surface. go.mod-only.
Follow-ups (non-blocking — file as issues)
- This pin is a moving target: it points at one specific commit, not a tag. Every time an external consumer needs newer root code they'll re-bump it by hand, and there's no CI guard that the pinned version stays resolvable. A tagged release of the root module, or a freshness check, would make this self-maintaining. Not this PR's job.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify/worldidis a separate module meant to be imported by external repos (scope3data/rtdp, for the World Ads operator path), but itsgo.modrequiredadcp-go v0.0.0— a placeholder that only resolves in-repo via thereplace => ../... External consumers ignore the replace, so the require failed to resolve and the module couldn't be imported.Pins the require to the real pseudo-version of the module's commit; keeps the replace for in-repo local dev (so adcp-go CI still builds against local root).
Validated: a scratch module that replaces only
verify/worldidto local now resolvesadcp-goroot from the proxy and builds — confirming external import works.🤖 Generated with Claude Code