Skip to content

Verify that request is not null. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuriyshafranyuk1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Verify that request is not null. #362

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b4db8d
Verify that request is not null.
yuriyshafranyuk1 Mar 29, 2017
5285ccd
Removed no needed parenthesis
yuriyshafranyuk1 Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/littleshoot/proxy/impl/ClientToProxyConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ void respond(ProxyToServerConnection serverConnection, HttpFilters filters,
// if this HttpResponse does not have any means of signaling the end of the message body other than closing
// the connection, convert the message to a "Transfer-Encoding: chunked" HTTP response. This avoids the need
// to close the client connection to indicate the end of the message. (Responses to HEAD requests "must be" empty.)
if (!ProxyUtils.isHEAD(currentHttpRequest) && !ProxyUtils.isResponseSelfTerminating(httpResponse)) {
if ((currentHttpRequest != null && !ProxyUtils.isHEAD(currentHttpRequest)) && !ProxyUtils.isResponseSelfTerminating(httpResponse)) {

@mjallday mjallday Mar 30, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there is one set of redundant parenthesis here.

// if this is not a FullHttpResponse, duplicate the HttpResponse from the server before sending it to
// the client. this allows us to set the Transfer-Encoding to chunked without interfering with netty's
// handling of the response from the server. if we modify the original HttpResponse from the server,
Expand Down