WIP: framework for gaussian heat source#414
Open
colemanjs wants to merge 9 commits intoadamantine-sim:masterfrom
Open
WIP: framework for gaussian heat source#414colemanjs wants to merge 9 commits intoadamantine-sim:masterfrom
colemanjs wants to merge 9 commits intoadamantine-sim:masterfrom
Conversation
Rombur
reviewed
Nov 14, 2025
colemanjs
force-pushed
the
gaussian-heat-source
branch
from
86b11a5 to
3cf1ef6
Compare
Contributor
Author
|
@Rombur, just a note that this implementation is a work in progress for the definition of the heat source for HPC4. Based on the calibration results, this may change to a super-gaussian with a slightly different mathematical form. Once validation is complete, I can mark this ready for review |
Member
|
Sounds good |
colemanjs
force-pushed
the
gaussian-heat-source
branch
from
89bb6d2 to
3d74514
Compare
Rombur
reviewed
Apr 20, 2026
Member
Rombur
left a comment
Rombur
left a comment
There was a problem hiding this comment.
This looks OK but it needs a test
| : HeatSource<dim>(beam_database, units_optional_database), | ||
| _five_axis(this->_scan_path.is_five_axis()) | ||
| { | ||
| _A = beam_database.get<double>("A"); |
Member
There was a problem hiding this comment.
When you read an input from the property tree, add a comment like:
// PropertyTreeInput sources.beam_X.A
I use that to grep the code and make sure that the documentation is up-to-date
| get_bounding_box(double time, double const scaling_factor) const final; | ||
|
|
||
| private: | ||
| double _A; |
Member
There was a problem hiding this comment.
Can you add a comment here. I have no idea what are A and B
Co-authored-by: Bruno Turcksin <[email protected]>
Co-authored-by: Bruno Turcksin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidate branch for implementing gaussian heat source