Skip to content

Issue #3178 - Fix error output in k8s mode #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronthebaron wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Issue #3178 - Fix error output in k8s mode #4308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Runner.Worker/Container/ContainerHooks/ContainerHookManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ public string GetContainerHookData()

private async Task<T> ExecuteHookScript<T>(IExecutionContext context, HookInput input, ActionRunStage stage, string prependPath) where T : HookResponse
{
bool stepFailed = false;
try
{
ValidateHookExecutable();
Expand Down Expand Up @@ -167,12 +168,13 @@ private async Task<T> ExecuteHookScript<T>(IExecutionContext context, HookInput
await handler.RunAsync(stage);
if (handler.ExecutionContext.Result == TaskResult.Failed)
{
stepFailed = true;
throw new Exception($"The hook script at '{HookScriptPath}' running command '{input.Command}' did not execute successfully");
}
var response = GetResponse<T>(input);
return response;
}
catch (Exception ex)
catch (Exception ex) when (!stepFailed)
{
throw new Exception($"Executing the custom container implementation failed. Please contact your self hosted runner administrator.", ex);
}
Expand Down