Skip to content

Add new option 'additional_dependencies'#131

Closed
lmignon wants to merge 1 commit intomasterfrom
master-additional-dependecies
Closed

Add new option 'additional_dependencies'#131
lmignon wants to merge 1 commit intomasterfrom
master-additional-dependecies

Conversation

@lmignon
Copy link
Copy Markdown
Member

@lmignon lmignon commented Mar 27, 2026

used to specify additional dependencies that are not declared in the addons manifests.

used to specify additional dependencies that are not declared in the addons manifests.
@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented Mar 27, 2026

Hm, I think this is not necessary here, because you can add an install_requires key in setup() with the additional dependencies and it will be extended with the dependencies computed from __manifest__.

@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented Mar 27, 2026

Here:

elif isinstance(v, list):
# list set in setup.py, extend with what we get from __openerp__.py
# (for install_requires, classifiers, etc)
assert isinstance(val, list)
for item in val:
if item not in v:
v.append(item)

@lmignon lmignon closed this Mar 27, 2026
@sbidoul sbidoul deleted the master-additional-dependecies branch March 27, 2026 08:48
@lmignon
Copy link
Copy Markdown
Member Author

lmignon commented Mar 27, 2026

Hm, I think this is not necessary here, because you can add an install_requires key in setup() with the additional dependencies and it will be extended with the dependencies computed from __manifest__.

:-( At least it made me read that code a little more carefully once, but it seems I didn't understood it closely enough (even though its usefulness is declining. . .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants