[RFR] replace pkg_resources dependency by other dependencies#128
Draft
thomaspaulb wants to merge 2 commits intoacsone:masterfrom
Draft
[RFR] replace pkg_resources dependency by other dependencies#128thomaspaulb wants to merge 2 commits intoacsone:masterfrom
thomaspaulb wants to merge 2 commits intoacsone:masterfrom
Conversation
sbidoul
reviewed
Feb 19, 2026
Member
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
Sounds good. Probably needs to work on the tox config to test with setuptools<82.
Nor urgency though as the existing workarounds work well.
| from importlib.resources import files | ||
| except ImportError: | ||
| # Fallback for Python < 3.9 | ||
| from importlib_resources import files |
Member
There was a problem hiding this comment.
I prefer to do this with if sys.version_info < (3, 9). Easier to spot if and when we drop support for older pythons.
| import subprocess | ||
|
|
||
| from pkg_resources import parse_version | ||
| import packaging |
Member
There was a problem hiding this comment.
Suggested change
| import packaging | |
| from packaging.version import parse_version |
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at #127
Wanted to give this an honest shot, but I'm not sure I'm going to be able to finish this