Skip to content

[IMP] label_modified_addons: improve performance. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legalsylvain wants to merge 2 commits into
base: label-pr-modified-addons
Choose a base branch
from
+11 −5
Open

[IMP] label_modified_addons: improve performance. #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb42fbd
[IMP] label_modified_addons: improve performance.
legalsylvain Apr 7, 2026
cbac322
[IMP] label_modified_addons: call only single replace_labels, with ma…
legalsylvain Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/oca_github_bot/tasks/label_modified_addons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,16 @@ def _label_modified_addons(gh, org, repo, pr, dry_run):
if not modified_addons:
return
gh_issue = github.gh_call(gh_pr.issue)
repo_label_names = [label.name for label in gh_repo.labels()]
issue_label_names = [label.name for label in gh_issue.labels()]

new_labels = set()
Comment on lines +28 to 31
Copy link
Copy Markdown
Member

@sbidoul sbidoul Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo_label_names = [label.name for label in gh_repo.labels()]
issue_label_names = [label.name for label in gh_issue.labels()]
new_labels = set()
repo_label_names = [label.name for label in gh_repo.labels()]
issue_label_names = [label.name for label in gh_issue.labels()]
new_labels = issue_label_names.copy()

for modified_addon in modified_addons:
label_name = compute_module_label_name(modified_addon)
# We create label at repo level, because it is possible to
# to set description in create_label() function
# (and not in issue.add_labels())
if label_name not in [x.name for x in gh_repo.labels()] and not dry_run:
if label_name not in repo_label_names and not dry_run:
github.gh_call(
gh_repo.create_label,
name=label_name,
Expand All @@ -43,10 +45,14 @@ def _label_modified_addons(gh, org, repo, pr, dry_run):

if is_main_branch_bot_branch(target_branch):
new_labels.add(f"series:{target_branch}")
new_labels = new_labels - {label.name for label in gh_issue.labels()}
if new_labels and not dry_run:
for new_label in new_labels:
github.gh_call(gh_issue.add_labels, new_label)
new_labels |= {
x
for x in issue_label_names
if not (x.startswith("mod:") or x.startswith("series:"))
}

if not dry_run and new_labels != set(issue_label_names):
github.gh_call(gh_issue.replace_labels, list(new_labels))
Comment on lines +48 to +55
Copy link
Copy Markdown
Member

@sbidoul sbidoul Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new_labels |= {
x
for x in issue_label_names
if not (x.startswith("mod:") or x.startswith("series:"))
}
if not dry_run and new_labels != set(issue_label_names):
github.gh_call(gh_issue.replace_labels, list(new_labels))
if not dry_run and new_labels != issue_label_names:
github.gh_call(gh_issue.replace_labels, list(new_labels))



@task()
Expand Down
Loading