Add option for alternating row background colors#352
Open
oscarkcau wants to merge 2 commits intoachannarasappa:masterfrom
Open
Add option for alternating row background colors#352oscarkcau wants to merge 2 commits intoachannarasappa:masterfrom
oscarkcau wants to merge 2 commits intoachannarasappa:masterfrom
Conversation
Agent-Logs-Url: https://github.com/oscarkcau/ticker/sessions/6488913d-c2dd-464a-a82f-a497f35a3077 Co-authored-by: oscarkcau <1132514+oscarkcau@users.noreply.github.com>
…r-feature feat: add alternating row background color option
achannarasappa
requested changes
Apr 27, 2026
| // ApplyBackground applies a background color to a rendered terminal string, | ||
| // including re-applying after any terminal reset sequences so that fill spaces | ||
| // between styled chunks also receive the background color. | ||
| func ApplyBackground(text string, bgHex string) string { |
Owner
There was a problem hiding this comment.
Could this be replaced with lipgloss? Something like this: lipgloss.NewStyle().Background(lipgloss.Color(bgHex)).Render(rowContent)
|
|
||
| // GetRowAlternateBackground returns the resolved background color hex for alternate rows | ||
| func GetRowAlternateBackground(colorScheme c.ConfigColorScheme) string { | ||
| return getColorOrDefault(colorScheme.BackgroundRow, "#303030") |
Owner
There was a problem hiding this comment.
Could this be changed to #1c1c1c so that there is still contrast with the tag color?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to display alternating row background colors in the watchlist UI, improving visual clarity. It adds a new CLI/config option, updates configuration structs, and implements the logic to apply background colors to alternate rows. Supporting utility functions are also included for color resolution and terminal rendering.
Feature: Alternating Row Backgrounds
--show-row-backgroundand corresponding config optionShowAlternateRowBackgroundto enable alternating row backgrounds in the watchlist UI. [1] [2] [3] [4]background-rowcolor, and added logic to resolve and apply this color for alternate rows. [1] [2]UI Implementation
Utilities
style.goto resolve the alternate row background color and apply background color codes to terminal strings, ensuring consistent background coloring even across styled text segments. [1] [2]