Persistence Options + Comprehensive README#60
Conversation
* Replication Configuration * Gitignore and docker-compose * Updated the persistence_default.json * persistence working * updated * updated * README
|
Hey @BrettMayson / @coyotan, any chance you or one of your colleagues could take a look at this and maybe merge it? I'd love to have persistence :) |
There was a problem hiding this comment.
Pull request overview
This PR adds optional persistence configuration support to the container startup flow and significantly expands the README to document available environment variables (including persistence-related settings), addressing the “Persistence How?” documentation gap (Issue #44).
Changes:
- Add
PERSISTENCE_*environment variables and inject agame.gameProperties.persistencesection into the generated server config when set. - Add a
persistence_default.jsontemplate file and copy it into the image. - Expand README variable documentation across Steam/Network/RCON/Game/Game Properties/Persistence sections.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds comprehensive ENV documentation and a new Persistence section with examples/links. |
| launch.py | Generates persistence config in docker_generated.json when PERSISTENCE_* envs are provided. |
| Dockerfile | Introduces PERSISTENCE_* env defaults and includes persistence_default.json in the image. |
| persistence_default.json | Provides a default/template persistence JSON structure (databases/storages). |
| .gitignore | Ignores reforger/ directory artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@BrettMayson I resolved the immediate comments. Please let me know if there's any other gaps. I do have a follow-up feature branch that implements ALL 1.6 parameters and updated docs as well we can start to look at as well as upgraded the container to a new version. |
|
@AngriestBird I need you to look at the failing lint job and fix the issues in there before I can merge this |
|
@BrettMayson I assumed the linter failed due to the 403. I have reviewed the output and fixed the few linter errors. Please re-review when you have a second. |
Changes
Issues
Adds instructions in README to enable persistence as well as additional information and places for documentation.
Closes #44