Skip to content

fix(concerto-analysis): report AST instances in finding.element (closes #1645) - #1646

Open
Ashu-213 wants to merge 1 commit into
accordproject:mainfrom
Ashu-213:fix-analysis-finding-element
Open

Ashu-213 wants to merge 1 commit into
accordproject:mainfrom
Ashu-213:fix-analysis-finding-element

Conversation

@Ashu-213

Copy link
Copy Markdown

Closes #1645

Ensures CompareFinding.element consistently references the AST declaration or property node instance (ScalarDeclaration or Property) rather than a primitive string name, aligning with other comparers in concerto-analysis.

Changes

  • packages/concerto-analysis/src/comparers/scalar-declarations.ts:
    • Changed element from string (a.getName() / b.getName()) to the ScalarDeclaration instance (a).
  • packages/concerto-analysis/src/comparers/properties.ts:
    • Changed element in propertyDefaultChanged from string (a.getName()) to the Property instance (a).
  • packages/concerto-analysis/test/unit/compare.test.ts:
    • Updated tests for scalar extends, validator changes, and default value additions to assert finding.element equals the AST declaration/property node.

Flags

  • None. Improves data integrity and consistency for consumers inspecting finding.element.

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Copilot AI balanced review requested due to automatic review settings November 17, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@mira-accord-project

Copy link
Copy Markdown

Thank you for opening this, @ and welcome to the project. Your change makes the concerto-analysis comparers report the AST declaration or property node in finding.element, which matches the other comparers and fixes #1645. The tests now check that identity too.

What happens next: a maintainer from the Concerto team has been requested as reviewer and will look at the change against the codebase and the test coverage. We aim to give a first review within a few working days, and we will ask for changes if anything needs them before merge.


Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(concerto-analysis): report AST instances in finding.element

2 participants