Repository navigation
Conversation
accordproject#1645) Signed-off-by: ashup <ashuptdr4@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Thank you for opening this, @ and welcome to the project. Your change makes the concerto-analysis comparers report the AST declaration or property node in finding.element, which matches the other comparers and fixes #1645. The tests now check that identity too. What happens next: a maintainer from the Concerto team has been requested as reviewer and will look at the change against the codebase and the test coverage. We aim to give a first review within a few working days, and we will ask for changes if anything needs them before merge. Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this. |
Closes #1645
Ensures
CompareFinding.elementconsistently references the AST declaration or property node instance (ScalarDeclarationorProperty) rather than a primitive string name, aligning with other comparers inconcerto-analysis.Changes
packages/concerto-analysis/src/comparers/scalar-declarations.ts:elementfrom string (a.getName()/b.getName()) to theScalarDeclarationinstance (a).packages/concerto-analysis/src/comparers/properties.ts:elementinpropertyDefaultChangedfrom string (a.getName()) to thePropertyinstance (a).packages/concerto-analysis/test/unit/compare.test.ts:finding.elementequals the AST declaration/property node.Flags
finding.element.Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname