Repository navigation
Conversation
jamieshorten
left a comment
There was a problem hiding this comment.
You also need to update the package-lock
There was a problem hiding this comment.
Pull request overview
Updates the @accordproject/concerto-core dependency set to address vulnerability-scan findings by bumping uuid to a newer 11.x minor release.
Changes:
- Bumped
uuidinpackages/concerto-core/package.jsonfrom11.0.3to11.1.1. - Updated
package-lock.jsonto reflect the newuuidresolution (and currently includes additional lockfile metadata churn beyond theuuidchange).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/concerto-core/package.json | Updates the uuid dependency version for @accordproject/concerto-core. |
| package-lock.json | Updates the resolved uuid version and lockfile entries (currently with substantial unrelated changes). |
|
@ssaraamer ran the test failure through claude code: One test is failing across all 6 jobs with the same assertion error: AssertionError: expected promise to be rejected with an error including The test (should fail using bad URL and default model file loader) expects a 404 response when loading a non-existent model file from a GitHub URL, but GitHub's API is currently returning a 400 instead. This is an external service behavior change — the test asserts on the specific HTTP status code in the error message, and GitHub changed its response. Additionally, the DCO check is also failing (ACTION_REQUIRED) — the commit(s) likely aren't signed off with the Developer Certificate of Origin. Summary of two failures:
To fix: the DCO issue needs an amended commit with --signoff, and the test assertion should probably match on a broader pattern (or the test is flaky due to depending on external GitHub API behavior). |
uuid 11.1.1 includes bug fixes and minor improvements. This resolves container image vulnerability scan findings for downstream consumers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sara Amer <Sara.Amer@docusign.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sara Amer <Sara.Amer@docusign.com>
70b7519 to
654d60a
Compare
|
@jamieshorten looks like the dco check is passing now |
|
@sara-amer-ds we still have those failing tests to address. |
|
This PR is stale because it has been open with no activity. Remove the stale label or comment to keep it active. Only items with maintainer engagement are auto-closed. |
The external URL returns different HTTP status codes (400 vs 404) depending on the endpoint state. Assert on the error structure rather than a specific status code. Signed-off-by: Sara Amer <Sara.Amer@docusign.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This PR is stale because it has been open with no activity. Remove the stale label or comment to keep it active. Only items with maintainer engagement are auto-closed. |
Summary
uuiddependency in@accordproject/concerto-corefrom 11.0.3 to 11.1.1Test plan