Repository navigation
fix: replace console.warn() with debug library in JSONPopulator - #1134
Merged
mttrbrts merged 1 commit intoFeb 25, 2026
Merged
Conversation
Contributor
Author
23harshitkumar
force-pushed
the
fix/replace-console-warn-clean
branch
2 times, most recently
from
February 22, 2026 13:48
30b8852 to
6750dbe
Compare
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
23harshitkumar
force-pushed
the
fix/replace-console-warn-clean
branch
from
February 22, 2026 13:53
6750dbe to
a9d3b78
Compare
Contributor
Author
|
@mttrbrts resolved merge conflicts. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: N/A
Summary:
Replace
console.warn()call with the debug library inconcerto-core, following the same pattern established in #1125 (HTTPFileLoader).This is a cleaner version of #1133, targeting the v4.0.0 branch from the start.
Changes:
jsonpopulator.js: Adddebug('concerto:JSONPopulator')import and replaceconsole.warnfor TZ environment variable warningsWhy these changes:
console.warn()pollutes console output in production environments, CI pipelines, etc. The debug library allows users to opt-in to these warnings viaDEBUG=concerto:*when needed.Difference from main branch PR (#1133):
The v4.0.0 branch only requires changes to
jsonpopulator.js, as thebasemodelmanager.jsconsole.warn issue from the main branch PR doesn't exist in v4.0.0.Testing:
All tests pass locally.
Supersedes #1133 with cleaner git history