Skip to content

fix: replace console.warn() with debug library in JSONPopulator - #1134

Merged
mttrbrts merged 1 commit into
accordproject:v4.0.0from
23harshitkumar:fix/replace-console-warn-clean
Feb 25, 2026
Merged

mttrbrts merged 1 commit into
accordproject:v4.0.0from
23harshitkumar:fix/replace-console-warn-clean

Conversation

@23harshitkumar

@23harshitkumar 23harshitkumar commented Feb 15, 2026 •

Copy link
Copy Markdown
Contributor

Fixes: N/A

Summary:

Replace console.warn() call with the debug library in concerto-core, following the same pattern established in #1125 (HTTPFileLoader).

This is a cleaner version of #1133, targeting the v4.0.0 branch from the start.

Changes:

  • jsonpopulator.js: Add debug('concerto:JSONPopulator') import and replace console.warn for TZ environment variable warnings

Why these changes:
console.warn() pollutes console output in production environments, CI pipelines, etc. The debug library allows users to opt-in to these warnings via DEBUG=concerto:* when needed.

Difference from main branch PR (#1133):
The v4.0.0 branch only requires changes to jsonpopulator.js, as the basemodelmanager.js console.warn issue from the main branch PR doesn't exist in v4.0.0.

Testing:
All tests pass locally.


Supersedes #1133 with cleaner git history

@23harshitkumar

Copy link
Copy Markdown
Contributor Author

@mttrbrts Bravo!!

This PR, as you requested, does the same changes to the v4.0.0 branch as the PR #1133 did for main branch. Lmk if this works!

Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
@23harshitkumar
23harshitkumar force-pushed the fix/replace-console-warn-clean branch from 6750dbe to a9d3b78 Compare February 22, 2026 13:53
@23harshitkumar

Copy link
Copy Markdown
Contributor Author

@mttrbrts resolved merge conflicts. Ready for review!

@mttrbrts
mttrbrts merged commit fc8ce6b into accordproject:v4.0.0 Feb 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants