Repository navigation
test: Add unit test for unrecognized model element in ModelFile - #1132
Merged
mttrbrts merged 1 commit intoFeb 14, 2026
Merged
Conversation
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Contributor
Author
|
@mttrbrts @ekarademir The PR is ready for a review! |
mttrbrts
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: N/A
Problem:
The
ModelFileconstructor logic for handling unrecognized model elements was not covered by unit tests, leaving a potential gap in error handling verification. ATODOcomment intest/composer/i18n.jsrequested functional testing for this case, but it remained unimplemented.Summary
This PR adds a unit test to
concerto-core/test/composer/i18n.jsto verify that theModelFile.jsconstructor correctly throws anIllegalModelExceptionwhen encountering an unrecognized model element.This change fulfills a longstanding
TODOin the test file and improves functional coverage for error handling in the introspection module.Changes
// TODO (LG) functionally test this functionwith an actual test case.declarationsarray (with an unknown class type) triggers the expected error message:Unrecognised model element "...".Verification
check message in constructor()case.npm test).