Repository navigation
fix(concerto-core): correct typographical errors in comments and error messages - #1107
Merged
Merged
Conversation
…r messages Fix typos in 8 source files and 1 test file: - modelfile.js: Wilcard -> Wildcard (2), compatibillity -> compatibility - instancegenerator.js: Primitve -> Primitive - jsonpopulator.js: primitve -> primitive - serializer.js: resouce -> resource - objectvalidator.js: resouce -> resource (2) - resourcevalidator.js: Resouce -> Resource, identifer -> identifier (2), resouce -> resource (2) - typed.js: Overriden -> Overridden - relationship.js: compatability -> compatibility (2) - test/modelfile.js: update test to match corrected error message Closes accordproject#1106 Signed-off-by: Shubh-Raj <shubhraj625@gmail.com>
mttrbrts
approved these changes
Jan 11, 2026
mttrbrts
left a comment
Member
There was a problem hiding this comment.
Great catches, @Shubh-Raj. Could you do a similar scan of the v4.0.0 branch too?
Contributor
Author
Sure will raise a PR soon. |
This was referenced Jan 12, 2026
Contributor
Author
Done! Opened PR #1111 targeting v4.0.0 with 15 typo fixes across 8 files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1106
Fix typographical errors in user-facing error messages, comments, and JSDoc across
concerto-core.Changes
Wilcard→Wildcardin error messages (modelfile.js)compatibillity→compatibilityin comments (modelfile.js)Primitve/primitve→Primitive/primitive(instancegenerator.js, jsonpopulator.js)resouce→resourcein JSDoc (serializer.js, objectvalidator.js, resourcevalidator.js)$identifer→$identifierin comments (resourcevalidator.js)Overriden→Overriddenin JSDoc (typed.js)compatability→compatibilityin JSDoc (relationship.js)Flags
Screenshots or Video
N/A - documentation and error message fixes only
Related Issues
Author Checklist
--signoffoption of git commit.fork:branchname