Skip to content

fix(concerto-core): correct typographical errors in comments and error messages - #1107

Merged
mttrbrts merged 1 commit into
accordproject:mainfrom
Shubh-Raj:fix/typos-issue-1106
Jan 11, 2026
Merged

mttrbrts merged 1 commit into
accordproject:mainfrom
Shubh-Raj:fix/typos-issue-1106

Conversation

@Shubh-Raj

Copy link
Copy Markdown
Contributor

Closes #1106

Fix typographical errors in user-facing error messages, comments, and JSDoc across concerto-core.

Changes

  • Fixed Wilcard → Wildcard in error messages (modelfile.js)
  • Fixed compatibillity → compatibility in comments (modelfile.js)
  • Fixed Primitve/primitve → Primitive/primitive (instancegenerator.js, jsonpopulator.js)
  • Fixed resouce → resource in JSDoc (serializer.js, objectvalidator.js, resourcevalidator.js)
  • Fixed $identifer → $identifier in comments (resourcevalidator.js)
  • Fixed Overriden → Overridden in JSDoc (typed.js)
  • Fixed compatability → compatibility in JSDoc (relationship.js)
  • Updated test to match corrected error message (test/introspect/modelfile.js)

Flags

  • No functional changes - comments and string literals only
  • The method name reportNotResouceViolation was intentionally left unchanged as renaming it would be a breaking API change

Screenshots or Video

N/A - documentation and error message fixes only

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

…r messages

Fix typos in 8 source files and 1 test file:
- modelfile.js: Wilcard -> Wildcard (2), compatibillity -> compatibility
- instancegenerator.js: Primitve -> Primitive
- jsonpopulator.js: primitve -> primitive
- serializer.js: resouce -> resource
- objectvalidator.js: resouce -> resource (2)
- resourcevalidator.js: Resouce -> Resource, identifer -> identifier (2), resouce -> resource (2)
- typed.js: Overriden -> Overridden
- relationship.js: compatability -> compatibility (2)
- test/modelfile.js: update test to match corrected error message

Closes accordproject#1106

Signed-off-by: Shubh-Raj <shubhraj625@gmail.com>

@mttrbrts mttrbrts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches, @Shubh-Raj. Could you do a similar scan of the v4.0.0 branch too?

@mttrbrts
mttrbrts merged commit df83e9d into accordproject:main Jan 11, 2026
13 checks passed
@Shubh-Raj

Copy link
Copy Markdown
Contributor Author

Great catches, @Shubh-Raj. Could you do a similar scan of the v4.0.0 branch too?

Sure will raise a PR soon.

@Shubh-Raj

Copy link
Copy Markdown
Contributor Author

Great catches, @Shubh-Raj. Could you do a similar scan of the v4.0.0 branch too?

Done! Opened PR #1111 targeting v4.0.0 with 15 typo fixes across 8 files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: typos across concerto-core

2 participants