Repository navigation
feat(concerto-util): add MonetaryUtil support - #1102
Conversation
| "dependencies": { | ||
| "@supercharge/promise-pool": "1.7.0", | ||
| "debug": "4.3.7", | ||
| "n2words": "^3.0.0", |
There was a problem hiding this comment.
Please use a pinned/exact package version to prevent supply chain attacks.
dselman
left a comment
There was a problem hiding this comment.
LGTM - just one small change required for the dependency on n2words. Can you also check that this webpacks ok and the increase in the bundle size?
|
Fixed! I've pinned the n2words dependency to version 3.0.0. I also ran the build locally to verify the bundle size: Ready for review! |
|
Please address the build failures. |
|
@dselman Done! Ready for review |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Commenting to reopen |
|
Please resolve merge errors and I will commit. |
c310f89 to
47c2fc6
Compare
Signed-off-by: Aadityavardhan Singh <singhrashmi018@gmail.com>
436f0c7 to
1b7be93
Compare
|
@dselman done! Ready for review. |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Be home, bot.
…On Sun, 22 Feb 2026, 07:47 github-actions[bot], ***@***.***> wrote:
*github-actions[bot]* left a comment (accordproject/concerto#1102)
<#1102 (comment)>
This PR is stale because it has been open 15 days with no activity. Remove
stale label or comment or this will be closed in 10 days.
—
Reply to this email directly, view it on GitHub
<#1102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYXRV65QZWNNFW2PPHPGJFT4NEGSZAVCNFSM6AAAAACQ54E7RCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMZZHEZTONRTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Description
This PR adds a new
MonetaryUtilclass to the@accordproject/concerto-utilpackage. This utility provides functionality to convert numbers into their written word representation (e.g., converting100to"one hundred"), utilizing then2wordslibrary.Motivation
As discussed in the previous meeting, there is a need for monetary text conversion support within the library to facilitate the upcoming implementation of the
Monetarytype in the core model. This utility lays the groundwork for that feature.Changes
lib/monetary.jscontaining theMonetaryUtilclass.n2wordstopackage.json.MonetaryUtilviaindex.jsfor external consumption.Verification
Next Steps
Once merged, this utility will be used by the
concerto-corelogic to handle monetary serialization and human-readable formatting.