Repository navigation
Conversation
- Update pretest script to build default-ruleset workspace before running lint - Prevents module resolution error on fresh clones/CI environments - Fixes test failure: Cannot find module '@accordproject/concerto-linter-default-ruleset' This ensures the dist/ folder exists before tests try to import from default-ruleset, fixing the developer experience for new contributors. Signed-off-by: Shubh-Raj <shubhraj625@gmail.com>
mttrbrts
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build order issue where linter tests fail on fresh clones due to a missing dependency build. The fix ensures the default-ruleset package is built before running tests.
Key Changes:
- Modified the pretest script to build the default-ruleset workspace before running lint
- Prevents module resolution errors when running tests in clean environments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Matt Roberts <7544022+mttrbrts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1096
Fix build order issue causing linter tests to fail on fresh clones by ensuring default-ruleset builds before tests run.
Changes
Flags
Screenshots or Video
Before Fix: npm test results in src/index.ts:19:31 - error TS2307: Cannot find module '@accordproject/concerto-linter-default-ruleset'. After Fix: All 18 tests pass successfully including configLoader.test.ts, lintModel.test.ts, loadRuleset.test.ts, and formatResults.test.ts
Related Issues
Author Checklist