discordChat: fix bug that caused multiplied duplicate records#1503
Merged
Conversation
also linter cleanup
Collaborator
|
@JamesHabben looks like one more linter thing to clean up, I guess "attachments" variable isn't used |
Collaborator
Author
|
@stark4n6 I did notice that one but didn't have the time or data sources to fully dig in. The bug I fixed here was taking 60 records and turning it into 62,000 because of the logic in the loop. I wanted to get that taken care of. I also noticed that there is a lot of duplication/overlap between the discordChats and discord_a module, so I was planning to come back around on that later. |
JamesHabben
changed the title
Collaborator
Author
|
@stark4n6 this pretty much makes discord_a duplicative / obsolete, but I didn't delete it yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also linter cleanup