Plugins - #3
Open
sfermigier wants to merge 96 commits into
Open
Conversation
Refact optparse
sfermigier
added a commit
that referenced
this pull request
May 26, 2026
Close two criticals from the 2026-05 security audit remediation plan
by adding safety interlocks around the test-mode auth bypass and the
deployment-log streaming endpoint.
- new core/unsafe_gate module: enforce_unsafe_mode_policy() runs at
server startup; HOP3_UNSAFE=true requires HOP3_UNSAFE_ACK set to
yes-I-understand or the server refuses to boot, and if MODE is
production the flag is forced off with a CRITICAL log rather than
honoured (closes critical #4)
- StreamController: add guards=[auth_guard] so /api/stream/{id}
requires a bearer token; previously anyone on the network could
guess a stream id and passively tail live deployment logs, which
routinely contain env vars, tokens, and database URLs
- streaming.create_stream: drop the str(uuid.uuid4())[:8] slice; full
UUIDv4 gives 122 bits of entropy, layered with the new auth_guard
attacker needs both a valid token and a lucky guess (closes
critical #3)
- tests cover ack-missing, wrong-ack, production-forced-off, default-
mode-production, truthy/falsy env spellings, the full-UUID shape,
and class-attribute wiring of the guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental plugin support.