Skip to content

Upstream fix is merged; scope the default to releases through 3.3.1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abahgat merged 1 commit into from
Aug 16, 2026
Merged

Upstream fix is merged; scope the default to releases through 3.3.1 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,9 @@ behind each verdict is unit-tested in `test_audit_classifier.py`.
## Upstream

The behaviour was reported as [microsoft/jericho#84][issue] and confirmed by a
maintainer; an upstream fix targeting a major release is tracked in
[microsoft/jericho#88][pr].
maintainer; the fix is [microsoft/jericho#88][pr], merged 2026-08-14 for the
v4.0 major release. Every release through 3.3.1 carries the silent default,
including the 3.2.0 this artifact pins.

[issue]: https://github.com/microsoft/jericho/issues/84
[pr]: https://github.com/microsoft/jericho/pull/88
Expand Down
2 changes: 1 addition & 1 deletion test_reading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test_committed_run_credits_randomization(artifact):
# --------------------------------------------------------------------------

def test_post_fix_run_reports_the_confound_absent():
"""The branch that matters once microsoft/jericho#88 lands.
"""The branch that matters on an engine carrying microsoft/jericho#88.

Numbers modelled on a real run against a patched build: the unseeded default
draws a fresh seed per episode (recorded as -1) and spreads across states, so
Expand Down
Loading