Add native squaremap integration - #1463
Open
mercurialmusic wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds native squaremap integration to Residence, following the structure of the existing Dynmap, BlueMap, and Pl3xMap integrations.
The implementation:
squaremap-apias an optional, provided dependency.SquareWebMapadapter using squaremap’s marker API.HideByDefault, andHideHidden.MapWorldinstances and safely handles replacement world registrations.The integration has been built and tested on a server with Residence and squaremap, including marker creation, updates, removal, hidden residences, subzones, multiple areas, and plugin shutdown cleanup.
Existing behavior noted during review
While reviewing the shared webmap lifecycle, a few pre-existing behaviors were identified that are outside the intended scope of this PR:
These behaviors affect the shared webmap system rather than squaremap specifically and are not addressed here to keep this PR focused on the new integration.
Thank you for the consideration.
Closes #1443