[Fix] Execute package installs without a shell - #748
Open
jsk1004ha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary
System package installation previously joined package names into a command string and executed it with
shell=True. That made package arguments pass through a shell parser and made the execution path harder to validate safely.This change:
subprocess.run([...])argument with no shell;PACKAGE_INSTALL_CMDSavailable for display and backward compatibility.Validation
PYTHONPATH=src python -m pytest -q tests/test_os_detect.py— 11 passedpython -m compileall -q src/hackingtool/os_detect.py tests/test_os_detect.py— passedThe tests cover argv construction, privilege escalation, Homebrew behavior, shell metacharacters remaining literal, invalid option-like/package inputs, unknown managers, execution errors, and an empty-package no-op.
Checklist
[Fix] ...formatAI assistance: the implementation and regression-test design were prepared with AI-assisted tooling; the focused checks above were rerun against the submitted source.