Remove FHS dependency by replacing /bin/bash with /usr/bin/env bash#5828
Merged
Conversation
mmicko
reviewed
Apr 22, 2026
Member
mmicko
left a comment
mmicko
left a comment
There was a problem hiding this comment.
While you are at it, there are actually 3 more files that needs updating techlibs/sf2/NOTES.txt, libs/minisat/00_UPDATE.sh and libs/fst/00_UPDATE.sh
Collaborator
Author
|
hmm, I'm pretty sure /bin/sh can be relied on as much as /usr/bin/env |
Collaborator
Author
|
I've asked for feedback elsewhere and asking env is supposedly proper for |
Member
I think it might not be: NixOS/nix#6081 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5768 on nixOS particularly due to
tests/aiger/generate_mk.py, verified locally on nixOS