Skip to content

Adjusted dot call to avoid pdflatex rejecting input due to too high resolution.#5807

Merged
KrystalDelusion merged 2 commits intoYosysHQ:mainfrom
petterreinholdtsen:docs-dot-dimensions
May 5, 2026
Merged

Adjusted dot call to avoid pdflatex rejecting input due to too high resolution.#5807
KrystalDelusion merged 2 commits intoYosysHQ:mainfrom
petterreinholdtsen:docs-dot-dimensions

Conversation

@petterreinholdtsen
Copy link
Copy Markdown
Contributor

Set fairly randomly picked size when generating dot graphs based on example I came across, to avoid the following error from pdflatex when building documentation:

  [46 <./rdata_map_luts.pdf>]
  ! Dimension too large.

I am not sure which size make sense, nor how to decide which value are best.

This issue is a fix for a build problem reported in <URL: https://bugs.debian.org/1133986 >, which include a link to the build log of the failed build.

@KrystalDelusion
Copy link
Copy Markdown
Member

The image in question is indeed quite large (and there is a bigger one right after it), but I can't reproduce the error you're seeing with a local make docs DOC_TARGET=latexpdf. Do you know if there is anything in the way that the latexpdf build is being done that is modified from the standard Yosys repo? Or any latexpdf settings?

In principle I don't have a problem with this change, though I will point out that the output pdf (at least when I build it with my local clone) has Page Size: 8.5 × 11 in (Letter, portrait), which seems like a better (less arbitrary) maximum image size (I'm sure you could find the actual maximum size within the margins, but the page size seems good enough for me).

@petterreinholdtsen
Copy link
Copy Markdown
Contributor Author

petterreinholdtsen commented Apr 16, 2026 via email

…esolution.

Set fairly randomly picked size when generating dot graphs based on
example I came across, to avoid the following error from pdflatex when
building documentation:

  [46 <./rdata_map_luts.pdf>]
  ! Dimension too large.

I am not sure which size make sense, nor how to decide which value are
best.

This issue is a fix for a build problem reported in
<URL: https://bugs.debian.org/1133986 >, which include a
link to the build log of the failed build.
Use US letter size as (a less arbitrary) max, since the final latexpdf size is the same.
Drop the ! since smaller images are fine.
Fix `x` -> `,` for `x,y` separator.
@KrystalDelusion KrystalDelusion enabled auto-merge May 4, 2026 22:24
@KrystalDelusion KrystalDelusion added this pull request to the merge queue May 4, 2026
Merged via the queue into YosysHQ:main with commit 8427bd3 May 5, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants