Adjusted dot call to avoid pdflatex rejecting input due to too high resolution.#5807
Merged
KrystalDelusion merged 2 commits intoYosysHQ:mainfrom May 5, 2026
Merged
Conversation
Member
|
The image in question is indeed quite large (and there is a bigger one right after it), but I can't reproduce the error you're seeing with a local In principle I don't have a problem with this change, though I will point out that the output pdf (at least when I build it with my local clone) has |
Contributor
Author
|
[KrystalDelusion]
Do you know if there is anything in the way that the latexpdf build is
being done that is modified from the standard Yosys repo? Or any
latexpdf settings?
I do not know.
As far as I can tell from the debian patches listed in
<URL: https://tracker.debian.org/pkg/yosys >, only
0026-Quiet-write-rst-command-ref-manual.patch and
0031-Set-pythonpath-for-usage-docs.patch touch files under docs/, and
none of them seem relevant to adjust how pdflatex is used.
…--
Happy hacking
Petter Reinholdtsen
|
…esolution. Set fairly randomly picked size when generating dot graphs based on example I came across, to avoid the following error from pdflatex when building documentation: [46 <./rdata_map_luts.pdf>] ! Dimension too large. I am not sure which size make sense, nor how to decide which value are best. This issue is a fix for a build problem reported in <URL: https://bugs.debian.org/1133986 >, which include a link to the build log of the failed build.
ad7435a to
c03c0d5
Compare
Use US letter size as (a less arbitrary) max, since the final latexpdf size is the same. Drop the ! since smaller images are fine. Fix `x` -> `,` for `x,y` separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set fairly randomly picked size when generating dot graphs based on example I came across, to avoid the following error from pdflatex when building documentation:
I am not sure which size make sense, nor how to decide which value are best.
This issue is a fix for a build problem reported in <URL: https://bugs.debian.org/1133986 >, which include a link to the build log of the failed build.