Skip to content

fix(ci): point dev-build and verification to KasetPlus.app - #39

Open
SnackForever wants to merge 1 commit into
Yoddikko:mainfrom
SnackForever:fix/ci-verify-release-app
Open

SnackForever wants to merge 1 commit into
Yoddikko:mainfrom
SnackForever:fix/ci-verify-release-app

Conversation

@SnackForever

@SnackForever SnackForever commented Sep 23, 2026 •

Copy link
Copy Markdown

User description

Description

Fixes the dev-build GitHub Actions workflow and release verification script to reference KasetPlus.app and accept com.sertacozercan.KasetPlus as a valid bundle identifier.

AI Prompt (Optional)

🤖 AI Prompt Used
Fix release packaging script and GitHub Actions CI workflow to support KasetPlus bundle identifier and artifact names.

AI Tool: Antigravity (Google DeepMind)

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📚 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Refactoring (no functional changes)
  • 🧪 Test update
  • 🔧 Build/CI configuration

Related Issues

N/A

Changes Made

  • .github/workflows/dev-build.yml:
    • Updated target artifact and DMG paths from Kaset.app to KasetPlus.app.
    • Updated volume name to KasetPlus-dev.
  • Scripts/verify-release-app.sh:
    • Added com.sertacozercan.KasetPlus to accepted bundle identifiers (valid_bundle_ids).
    • Dynamically resolved Sparkle mach services to match the active bundle identifier.

Testing

  • Unit tests pass (xcodebuild test -only-testing:KasetTests)
  • Manual testing performed
  • UI tested on macOS 26+

Checklist

  • My code follows the project's style guidelines
  • I have run swiftlint --strict && swiftformat .
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally
  • I have updated documentation if needed
  • I have checked for any performance implications
  • My changes generate no new warnings

Screenshots

N/A (CI and packaging script change)

Additional Notes

None


CodeAnt-AI Description

Align development builds and release checks with the KasetPlus app identity

What Changed

  • Development CI now verifies and packages KasetPlus.app instead of the old app name
  • Generated disk images now use the KasetPlus-dev volume name
  • Release verification accepts both existing Kaset and KasetPlus bundle identifiers
  • Sparkle update service checks now follow the packaged app’s active bundle identifier
  • Release verification no longer rejects apps solely because they are not sandboxed

Impact

✅ Successful KasetPlus development builds
✅ Working Sparkle verification for KasetPlus releases
✅ Correctly named development disk images

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI lite review requested due to automatic review settings September 23, 2026 11:49
@codeant-ai

codeant-ai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 0197c65 Sep 23, 2026 · 11:49 11:51

@codeant-ai

codeant-ai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Sep 23, 2026
@Yoddikko

Copy link
Copy Markdown
Owner

Hi @SnackForever thanks for the PR. I will take a look in these weeks, I'm quite busy

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants