Skip to content

Media: Skip cross-origin isolation on the classic-theme site editor home route #78404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 5 commits into from
Jun 1, 2026
+52 −0
Merged

Media: Skip cross-origin isolation on the classic-theme site editor home route #78404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bef68b1
Media: Send Document-Isolation-Policy header on the site preview frame
t-hamano May 18, 2026
648d5d5
Backport changelog: Link to wordpress-develop#12004.
adamsilverstein May 28, 2026
f5e6c4e
Merge branch 'trunk' into fix/site-preview-iframe-document-isolation-…
t-hamano May 29, 2026
cf04c31
Add e2e test for Site Preview iframe interactivity isolation
t-hamano May 29, 2026
f4932b0
Site preview: skip editor isolation instead of isolating the front end
t-hamano May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backport-changelog/7.1/12004.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
https://github.com/WordPress/wordpress-develop/pull/12004

* https://github.com/WordPress/gutenberg/pull/78404
7 changes: 7 additions & 0 deletions lib/media/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,13 @@ function gutenberg_set_up_cross_origin_isolation() {
return;
}

// Skip when rendering the classic-theme home route, which shows the site
// preview in an iframe and must reach its `contentDocument` to neutralize
// interactive elements — DIP would block that.
if ( 'site-editor' === $screen->id && ! wp_is_block_theme() && ( ! isset( $_GET['p'] ) || '/' === $_GET['p'] ) ) {
Copy link
Copy Markdown
Member

@adamsilverstein adamsilverstein Jun 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why the 'p' GET paramater check is needed, but trust you added it for a reason!

Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classic theme allows can use the block editor within the Site Editor. For example, it includes template parts and patterns, and the URLs will look like site-editor.php?p=/wp_block/1&canvas=edit. In this case, we should not disable DIP. For this reason, the 'p' GET parameter check is necessary.

return;
}

// Skip when a third-party page builder overrides the block editor.
// DIP isolates the document into its own agent cluster,
// which blocks same-origin iframe access that these editors rely on.
Expand Down
42 changes: 42 additions & 0 deletions test/e2e/specs/site-editor/site-preview.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/**
* WordPress dependencies
*/
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );

test.describe( 'Site preview', () => {
test.beforeAll( async ( { requestUtils } ) => {
// The site preview iframe is only rendered for classic (non-block) themes.
await requestUtils.activateTheme( 'twentytwentyone' );
} );

test( 'makes interactive elements inside the preview non-interactive', async ( {
admin,
page,
} ) => {
await admin.visitSiteEditor();

const previewFrame = page.frameLocator(
'iframe[title="Site Preview"]'
);

const interactiveSelector = [
'a[href]',
'button:not([disabled])',
'input:not([type="hidden"]):not([disabled])',
'select:not([disabled])',
'textarea:not([disabled])',
]
.map( ( selector ) => `${ selector }:visible` )
.join( ',' );
const interactiveElements = previewFrame.locator( interactiveSelector );

await expect( interactiveElements.first() ).toBeVisible();

const count = await interactiveElements.count();
for ( let i = 0; i < count; i++ ) {
const element = interactiveElements.nth( i );
await expect( element ).toHaveAttribute( 'aria-hidden', 'true' );
await expect( element ).toHaveCSS( 'pointer-events', 'none' );
}
} );
} );
Loading