Repository navigation
Conversation
Applied @willbooster/wbfy v20.23.2.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The wbfy update left the existing inline test job with an invalid reusable workflow call. After restoring the workflow, TypeScript 7 exposed a test runner assumption about the compiler's default strictness.
Requirements
required: Apply wbfy to
ultra-parserand continue until the PR can be merged.chosen: Keep the repository's inline CI test job because it runs the Maven, Rust, generation, and TypeScript checks already used by the project.
chosen: Set compiler strictness explicitly for runtime grammar tests because TypeScript 7 enables it by default.
Customer Summary
The repository receives the wbfy configuration update while retaining its full CI coverage.
Technical Summary
The inline test workflow runs unchanged. The TypeScript runtime test runner now enables strict checks for grammars without embedded code and disables them for grammars with embedded code, matching its existing test contract. A separate fix in WillBooster/shared prevents future wbfy runs from adding a reusable call to inline jobs.
Testing
bun run verifypassed.TypeScriptRuntimeTestsran 356 cases with no failures or errors. PR CI is running.Notes
The
semantic-pr / semantic-prcheck is required by the branch ruleset but itspull_request_targetworkflow is new in this PR, so GitHub cannot run that check until the workflow reachesmain.