Repository navigation
fix: scope generated workflow permissions - #1284
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the security posture of the project's CI/CD pipeline by scoping GitHub Actions token permissions. By explicitly defining the required permissions for each reusable workflow caller, the risk associated with over-privileged tokens is reduced. The changes include updates to the workflow generator logic, corresponding documentation, and a new test suite to ensure ongoing compliance with these security requirements. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Permissions tight and locked away, / To keep the workflows safe all day. / With minimal scope for every task, / Security is all we ask. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the workflow generator to explicitly define and restrict GitHub Actions token permissions for generated reusable workflow callers (test-rust, semantic-pr, and close-comment). It also updates the expected repository rules documentation to reflect these permission requirements and adds a unit test to verify that the generated workflows grant only the necessary permissions. I have no feedback to provide as there are no review comments and the changes align with the repository guidelines.
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Customer Summary
Technical Summary
@mainreusable-workflow call, including nonstandard filenames and job names.Why
Testing
bun run verifybun test packages/wbfy/test/unit/workflowPermissions.test.ts