Open
Conversation
Stebalien
force-pushed
the
steb/remove-f
branch
from
659746c to
80f4405
Compare
Stebalien
commented
Aug 10, 2025
| (setq library-name | ||
| (f-expand library-name | ||
| (f-parent find-function-C-source-directory)))) | ||
| (expand-file-name library-name |
Author
There was a problem hiding this comment.
This is slightly different in that it uses file-name handlers, but I'm pretty sure that's what we want (e.g., if the source directory is on a remote machine, in a docker container, etc.).
Comment on lines
+1338
to
+1339
| (file-name-directory | ||
| (directory-file-name find-function-C-source-directory))))) |
Author
There was a problem hiding this comment.
This is a bit unfortunate. Emacs 29 has file-name-parent-directory but that's rather new.
There were only 7 uses and 4 were aliases or thin wrappers around built-in functions.
Stebalien
force-pushed
the
steb/remove-f
branch
from
80f4405 to
7b53e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no strong opinions here so feel free to simply close this, but I'm trying to slim down my package list. There were only 7 uses and 4 were aliases or thin wrappers around built-in functions.