Skip to content

fix: Improve variable setting logic in helpful.el #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wilfred merged 1 commit into from
Feb 20, 2025
Merged

fix: Improve variable setting logic in helpful.el #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion helpful.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,9 @@ overrides that to include previously opened buffers."
(let* ((sym (button-get button 'symbol))
(buf (button-get button 'buffer))
(sym-value (helpful--sym-value sym buf))
(set-func (symbol-name helpful-set-variable-function))
(set-func (if (local-variable-p sym buf)
"setq"
(symbol-name helpful-set-variable-function)))
;; Inspired by `counsel-read-setq-expression'.
(expr
(minibuffer-with-setup-hook
Expand Down