fix: don't count javascript template strings as atoms#956
Open
paperclover wants to merge 1 commit intoWilfred:masterfrom
Open
fix: don't count javascript template strings as atoms#956paperclover wants to merge 1 commit intoWilfred:masterfrom
paperclover wants to merge 1 commit intoWilfred:masterfrom
Conversation
if template strings are atoms, changing the indentation of a block of
code containing one counts that as a change, which is bad. instead,
recurse the expression as normal.
not very happy with adding a special case to `atom_from_cursor` but i'm
not familiar enough to know the right strategy.
test case
```ts
let x = `hello ${y
? 1
: 2
}`;
```
```ts
{
let x = `hello ${y
? 1
: 2
}`;
}
```
400c909 to
98ac870
Compare
|
Owner
|
This usually doesn't work, unfortunately, which is why strings with interpolated expressions are treated as atoms in most cases. The problem is that the text before and after the interpolation needs to be present in the AST, or difftastic won't understand that the following string literals are different. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



if template strings are atoms, changing the indentation of a block of code containing one counts that as a change, which is bad. instead, recurse the expression as normal.
not very happy with adding a special case to
atom_from_cursorbut i'm not familiar enough to know the right strategy.test case