Open
Conversation
01e76d4 to
412c698
Compare
|
Hello, I'm pure.fish lead dev and was looking for a Fish support PR. What a nice surprise to see you tested on it 😃 |
Contributor
Author
|
idk, I've just took the opportunity to rebase this PR. Maybe you can help with my open questions from the PR description. |
|
The tree-sitter wiki mention a Fish parser https://github.com/ram02z/tree-sitter-fish The doc on adding a parser mention how to check you set the correct values for atoms and delimiters : difftastic/manual/src/adding_a_parser.md Lines 68 to 70 in cc06434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add supports for the fish scripting language.
https://fishshell.com/
I am not completely sure if atom_nodes and delimiter_tokens are correct. But it seems to be working for me.
Tested using the diff of this PR: pure-fish/pure#375