Emit sorted dir-diff result as soon as preceding results get ready#603
Open
yuja wants to merge 2 commits intoWilfred:masterfrom
Open
Emit sorted dir-diff result as soon as preceding results get ready#603yuja wants to merge 2 commits intoWilfred:masterfrom
yuja wants to merge 2 commits intoWilfred:masterfrom
Conversation
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
b8948b8 to
d67d719
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
2 times, most recently
from
f3bcd71 to
4d2f683
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
4d2f683 to
061df36
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
061df36 to
4ad4f18
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
2 times, most recently
from
9313712 to
19fd6e2
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
2 times, most recently
from
17e2647 to
e482293
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
2 times, most recently
from
d775351 to
2ee8cc0
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
2 times, most recently
from
12edce3 to
bd2e3d0
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
2 times, most recently
from
a467b45 to
f853e36
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
829ba54 to
a5cc56e
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
a5cc56e to
d97bdf0
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
d97bdf0 to
1753f39
Compare
yuja
force-pushed
the
push-nprqmzptuyvz
branch
from
1753f39 to
da01bc2
Compare
This ensures that the json output is also sorted.
If the directory diff contains lots of changes across files, it's better to emit earlier results incrementally. The idea is borrowed from the following thread. The diff producer assigns incremental index, and the consumer puts the results in BinaryHeap to reorder them by index. https://users.rust-lang.org/t/parallel-work-collected-sequentially/13504/3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the directory diff contains lots of changes across files, it's better to
emit earlier results incrementally.
The idea is borrowed from the following thread. The diff producer assigns
incremental index, and the consumer puts the results in BinaryHeap to reorder
them by index.
https://users.rust-lang.org/t/parallel-work-collected-sequentially/13504/3