Feat: Allow for notification support. - #41
Open
Humanoidear wants to merge 1 commit into
Open
Humanoidear wants to merge 1 commit into
Humanoidear wants to merge 1 commit into
Conversation
hwalker56
requested changes
Sep 2, 2026
hwalker56
left a comment
hwalker56
left a comment
Member
There was a problem hiding this comment.
Generally LGTM. My one complaint would be the use of usernames in DB tables. I'm aware this is also done for coupon redemptions, but I'd much prefer using a unique identifier provided by OIDC.
Member
Author
|
Since usernames must be unique I figured I would use them in the tables for verbosity. |
Member
|
While they are unique, we allow people to change their username. Using a static user ID alongside the username for verbosity only would be far better. |
Allow subscribing and receiving notifications on all devices, as well as sending notifications as admin.
Humanoidear
force-pushed
the
Feat-Notifications
branch
from
September 3, 2026 18:53
5d1a279 to
9865b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow subscribing and receiving notifications on all devices, as well as sending notifications as admin.