Conversation
glasserm
reviewed
Aug 20, 2026
| # cumTP=$endIdx | ||
| # fi | ||
| # done | ||
| # No pre-existing concat file, so build one ourselves. |
Contributor
There was a problem hiding this comment.
Single runs also need to be variance normalized using the ${ProcString}_vn file before concatenating and then unvariance normalized by the average of those ${ProcString}_vn files. If PFMs are to be run in variance normalized mode (which we have determined in macaques is a good idea) then we need to reapply the average variance normalization before running PFMs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.