Repository navigation
chore(local-testing): keep race and session pickers error-free when empty - #371
Merged
Merged
Conversation
…mpty
A Postgres variable query that returns zero rows reaches Grafana as a frame
with no fields, and Grafana's variable code throws "Couldn't find any field
of type string in the results." on it. Return a ('', 'None') placeholder row
when there are no races, or no sessions for the selected race.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Race picker (Laps and Race Control) and the Session picker (Laps) show an error icon whenever their query returns no rows, e.g. on a fresh local stack with an empty
racestable, or when no race is selected.A Postgres variable query with zero rows reaches Grafana as a frame with no fields, and Grafana 13's variable code throws
Couldn't find any field of type string in the results.on it. Both queries now return a single('', 'None')placeholder row only when there is nothing else to list; populated lists are unchanged. Panels already match nothing for an empty race/session, so the placeholder doesn't change what they render.Testing
tests/test_dashboards.pycover the empty and populated cases for both pickers (empty cases failed before the change)./api/ds/queryagainst the empty DB: both return typed__value/__textstring fields with theNonerow.🤖 Generated with Claude Code