Repository navigation
chore(local-testing): keep race panels error-free when no race is selected - #369
Merged
Merged
Conversation
…ected Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Laps, Race Control, and Standings dashboards derive the hidden
race_from/race_tovariables from the selected race. When no race is selected — e.g. a fresh local stack with an emptyracestable — those queries returned no row, the variables were empty, and every panel filtering ontime >= ${race_from}msfailed withinvalid operation: time and *influxql.VarRef are not compatible.Both queries now aggregate with
max()so they always return one row:race_fromfalls back to0andrace_totonow. With no race selected, the panels show "No data" instead of an error. For a selected race the values are unchanged, includingnowfor a race with noend_timeyet.Verified against the local stack: the new and old SQL return identical values for a finished race and an open race, and every race-dependent panel across the three dashboards now queries without error when no race exists.
🤖 Generated with Claude Code