fix: add pagination to getAccountRoles - #108
Merged
AndreasAugustin merged 1 commit intoMay 18, 2026
Merged
AndreasAugustin merged 1 commit into
AndreasAugustin merged 1 commit into
Conversation
ListAccountRoles API now paginates results, causing some roles to be missing. Added nextToken handling to fetch all pages, matching the pattern already used in listAccounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListAccountRoles API now paginates results, causing some roles to be missing. Added nextToken handling to fetch all pages, matching the pattern already used in listAccounts.
Description
`ListAccountRoles` API started paginating results, causing only the first page of roles to be displayed. This resulted in missing roles for some
accounts.
Changes
Added `nextToken` handling to `getAccountRoles` to fetch all pages, matching the pattern already used in `listAccounts`.
Testing
Verified locally that all roles now appear for affected accounts."