fix: avoid e2e teardown panic after setup failure#2231
Merged
AndrewChubatiuk merged 1 commit intoJun 1, 2026
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
AndrewChubatiuk
approved these changes
Jun 1, 2026
Contributor
AndrewChubatiuk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShutdownOperatorProcess()can panic if suite startup exits beforecancelManageris set. Then the real setup error gets buried, kinda noisy.This just guards the "manager never started" path and adds a small regression test.
Repro
go test ./test/e2e -run TestE2E.SynchronizedBeforeSuitefails andSynchronizedAfterSuitepanics on nilcancelManager.Summary by cubic
Prevent e2e teardown panics when setup fails by safely handling cases where the operator manager never started. Teardown now skips manager shutdown and surfaces the original setup error.
Written for commit 3462f93. Summary will update on new commits.