Skip to content

added overlay without namespace and fixed certs for custom namespace#2226

Merged
AndrewChubatiuk merged 1 commit into
masterfrom
fix-kustomize-issues
Jun 1, 2026
Merged

added overlay without namespace and fixed certs for custom namespace#2226
AndrewChubatiuk merged 1 commit into
masterfrom
fix-kustomize-issues

Conversation

@AndrewChubatiuk

@AndrewChubatiuk AndrewChubatiuk commented May 29, 2026

Copy link
Copy Markdown
Contributor

address issues #1315 and #279


Summary by cubic

Adds a namespace-less overlay and moves cert-manager into a dedicated overlay with correct CA/DNS wiring. Updates manifests to use the new overlay so installs work in custom namespaces.

  • New Features

    • Added base overlay without Namespace at config/base-without-namespace (deletes vm Namespace for custom setups).
    • Introduced config/default-with-certmanager that bundles webhook + cert-manager and applies CA injection/DNS replacements.
    • Simplified config/default-with-webhook to webhook-only; cert-manager no longer included there.
  • Bug Fixes

    • Certificates now derive dnsNames and CA injection from the webhook Service name/namespace, fixing installs outside the vm namespace.

Written for commit fcf727f. Summary will update on new commits.

Review in cubic

@AndrewChubatiuk AndrewChubatiuk requested a review from vrutkovs as a code owner May 29, 2026 14:01

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

@vrutkovs

vrutkovs commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

I wonder if its easy to add some tests on this?

@AndrewChubatiuk

Copy link
Copy Markdown
Contributor Author

I've just tried it locally, for testing probably some custom tools are needed, haven't seen any ready solution

@AndrewChubatiuk AndrewChubatiuk merged commit 4baec6e into master Jun 1, 2026
7 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the fix-kustomize-issues branch June 1, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom namespace not respected in certificate dnsNames Remove the namespace object or rename it victoriametrics

2 participants