vmalertmanagerconfig: add incidentio_config file-based properties support#2225
Open
AndrewChubatiuk wants to merge 1 commit into
Open
vmalertmanagerconfig: add incidentio_config file-based properties support#2225AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="api/operator/v1beta1/vmalertmanagerconfig_types.go">
<violation number="1" location="api/operator/v1beta1/vmalertmanagerconfig_types.go:1498">
P2: Missing URLFile block in arbitrary FS validation. `url_file` still allows file-path based config when deny mode should reject file-based inputs. Add URLFile check in `validateArbitraryFSAccess()`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
c9ccd34 to
63c234b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2222
Summary by cubic
Add file-based incident.io config to VMAlertmanagerConfig via
url_fileandalert_source_token_file, so URL and token can be read from files. Enforces mutual exclusivity with existing fields and disallows token file when arbitrary FS access is restricted (fixes #2222).url_fileandalert_source_token_fileto IncidentioConfig; mutually exclusive withurlandalert_source_token.alert_source_token_filewhen arbitrary FS access is disabled.Written for commit 63c234b. Summary will update on new commits.
Review in cubic