vmcluster/vmsingle: support downsampling and retention filters#2224
Open
AndrewChubatiuk wants to merge 1 commit into
Open
vmcluster/vmsingle: support downsampling and retention filters#2224AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 13 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
support-downsampling-and-retention-filters
branch
3 times, most recently
from
83b6f64 to
6f7673c
Compare
Contributor
Author
|
@cubic-ai-dev |
Contributor
@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
1 issue found across 14 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
commented
May 29, 2026
AndrewChubatiuk
force-pushed
the
support-downsampling-and-retention-filters
branch
from
c1e6af7 to
a7168d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2221
related issue VictoriaMetrics/helm-charts#2221
Summary by cubic
Adds structured downsampling and per-series retention filters to
VMSingleandVMCluster. The operator validates enterprise settings and renders flags with strict interval rules and correct dedup defaults.New Features
spec.downsamplingforVMSingleandVMClusterwith rules{filter?, periods:[{offset, interval}]}and optionaldedupInterval; applied tovmselectandvmstorage.spec.retentionFiltersforVMSingle, andspec.vmstorage.retentionFiltersforVMCluster.license; parses MetricsQL filters and durations; enforcesoffsetis a multiple ofinterval; period intervals in a rule are pairwise multiples;dedupIntervalmust divide all rule intervals; duplicate rule filters are rejected; per-seriesretentionmust not exceedspec.retentionPeriod.-downsampling.periodper period (prefixed withfilterwhen set), set-dedup.minScrapeIntervalfromdedupIntervaland otherwise default to1msonly when not provided, and emit-retentionFilteronVMSingleandVMClustervmstorage.extraArgs.Migration
spec.downsamplingandspec.retentionFiltersoverextraArgs; set enterprise image/tag andspec.license. Usespec.retentionPeriodfor the default retention.Written for commit a7168d8. Summary will update on new commits.