Release 0.68.6 PR

[vrutkovs]

No description provided.

[cubic-dev-ai]

1 issue found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/controller/operator/factory/reconcile/statefulset.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset.go:224">
P2: The early return skips syncing `status.currentReplicas` when `currentRevision` is already up to date, so replica status can remain stale on later reconciles/scale events.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[cubic-dev-ai]

P2: The early return skips syncing status.currentReplicas when currentRevision is already up to date, so replica status can remain stale on later reconciles/scale events.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At internal/controller/operator/factory/reconcile/statefulset.go, line 224:

<comment>The early return skips syncing `status.currentReplicas` when `currentRevision` is already up to date, so replica status can remain stale on later reconciles/scale events.</comment>

<file context>
@@ -212,13 +212,32 @@ type rollingUpdateOpts struct {
+	if err := rclient.Get(ctx, nsn, &sts); err != nil {
+		return fmt.Errorf("cannot get statefulset for status update: %w", err)
+	}
+	if sts.Status.CurrentRevision == updateRevision {
+		return nil
+	}
</file context>

Suggested change

	if sts.Status.CurrentRevision == updateRevision {
	return nil
	}
	if sts.Status.CurrentRevision == updateRevision && sts.Status.CurrentReplicas == replicas {
	return nil
	}