lib/logstorage: add pipe json_array_concat#1408
Open
cuongleqq wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="lib/logstorage/pipe_json_array_concat.go">
<violation number="1" location="lib/logstorage/pipe_json_array_concat.go:135">
P2: Leading whitespace causes valid JSON arrays to be rejected before parsing, so the pipe returns an empty string for inputs the JSON parser accepts.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
64393a4 to
7bbc170
Compare
7bbc170 to
d0dccc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #712
This PR adds the
json_array_concatpipe for joining JSON array items stored in a log field into a single string with a given delimiter.Syntax:
json_array_concat [delimiter] [from <src_field>] [as <result_field>]delimiteris optional, defaults to empty string (items concatenated without separator)from <src_field>is optional, defaults to_msgas <result_field>is optional, defaults to<src_field>(in-place)